[
https://issues.apache.org/jira/browse/ODE-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830248#action_12830248
]
David Carver commented on ODE-751:
----------------------------------
In the ode-engine project, in BpelDAOConnectionImpl.compareInstanceUsingKey
method, there is a possiblity that both s1 and s2 can be null, in which case a
Nullpointer exception can occur at the end of the method. Ideally there
should be a default value returned from this method if they are null. For s2
if comparing to s1 I would assume a -1 would be returned since s2 < s1 when s2
is null.
the opposite would be true when comparing s1 to s2 when s1 is null.
I can make this change if you guys agree.
> FindBugs Patches for ODE Runtime
> --------------------------------
>
> Key: ODE-751
> URL: https://issues.apache.org/jira/browse/ODE-751
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Environment: linux
> Reporter: David Carver
> Assignee: Rafal Rusin
> Attachments: mylyn-context.zip, ode-bpel-compilepatchv1.txt,
> ode-bpel-runtimepatchv1.txt, ode-il-common-patchv1.txt,
> ode-jacob-patchv1.txt, ode-jbi-patchv1.txt, ode-jca-rapatchv1.txt,
> ode-jca-serverpatchv1.txt, odebpelapipatchv2.txt, odebpeldapatchv1.txt,
> odebpelpatch.txt, odeutilspatchv1.txt, schedule-simple-patchv1.txt
>
>
> Running FindBugs (http://findbugs.sourceforge.net/) against the bpel-api
> project, the following error:
> Equals method for org.apache.ode.bpel.iapi.Endpoint assumes the argument is
> of type Endpoint
> Will attach a patch to correct these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
