[ 
https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507972
 ] 

David E. Jones commented on OFBIZ-1096:
---------------------------------------

In general I like this enhancement, and it finally gets some things into the 
form widget that we've had in the ecommerce category pagination for a long time.

As for the new attributes... there was some discussion a little while back 
about the fact that there are already too many attributes on the form element. 
It might be good to start putting all new style attributes in a new 
sub-element, as was discussed before. I tried looking around for the issue but 
after 15 minutes I'm out of time on this. I'm sure it's in there somewhere, 
maybe closed and that's why I couldn't find it in the searches I did.

Anyway, that's the main thing that should probably change so we don't get too 
much (more!) attribute bloat in the form element. The name of the sub-element 
was in that issue somewhere and we should probably just with that (unless it 
makes no sense, I don't remember as it was too long ago we discussed that). 
Something like "form-styles" or just "styles" would be good, and then "-style" 
can be removed from all of the attribute names.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files 
> in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well 
> as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with 
> the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk 
> version.
> PS: I would like to use this issue to have your comments on another pager 
> issue. The current implementation doesn't support pages that display more 
> than one list form for the obvious reason that the only the parameters 
> VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to 
> differentiate the form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to