[
https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508031
]
Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------
Jacopo:
It is possible to display it on Top, i will work on it. In fact i already have
the call to render the pager on top in my local version, but some elements
necessary to the pager are computed when the list is rendered (such as listSize
...)
In Neogia they made the calculation in the pager rendering code which is imho
not elegant.
About the attributes, i just added them to be consistent. And i also noticed
that labels are hard coded in English, shouldn't we use uiLabels in the Form
code ? I think that would remove any use for the label attributes.
For style attributes, i would not use them i think. If that were up to me i
would probably prefer to hard code CSS classes in the pager rendering code and
let people change their CSS. In my previous version i had these, in the patch
only the classes for the the table cells remains in the code (needed to style
the pager buttons with arrow images rather than text).
There is also the FTL issue, they won't share this piece of code ... in my
local version i had a set of FTL macros that would perform the same result but
i had to import code from Opentaps into the framework to support their custom
tag for importing FTL files.
But since most of the FTLs comes along with a BSH i would still prefer to see
them disappear :)
> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files
> in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well
> as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with
> the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk
> version.
> PS: I would like to use this issue to have your comments on another pager
> issue. The current implementation doesn't support pages that display more
> than one list form for the obvious reason that the only the parameters
> VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to
> differentiate the form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
