Adrian,

I've not followed the details of your design, and so sorry if my comment is out of scope here... the main reason for the ApacheFopFactory class is that it implements a singleton. Maybe you have already addressed this in another class but it was worth of a mention.

Jacopo



Adrian Crum wrote:
Jonathon -- Improov wrote:
Seems a bit counter-intuitive, that design pattern. Or we could rename ApacheFopWorker to ApacheFopFactoryHelper.

You're right, but my thinking is the ApacheFopFactory class could be phased out. From my perspective, it seems kind of silly to have a class that does nothing more than return an instance of another class.

-Adrian

Reply via email to