Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java RecordIterator.java

[Jacques Le Roux]

Le 28/10/2017 à 16:45, mbr...@apache.org a écrit :

      /**
       * little endian reader for 4 byte int.
       */
-    public final int readLEInt(byte []byteArray) {
-    return
-    (byteArray[3])      << 24 |
-    (byteArray[2]&0xff) << 16 |
-    (byteArray[1]&0xff) <<  8 |
-    (byteArray[0]&0xff);
+    public final int readLEInt(byte[] byteArray) {
+        return (byteArray[3]) << 24 | (byteArray[2] & 0xff) << 16 | (byteArray[1] & 
0xff) << 8 | (byteArray[0] & 0xff);
      }

/**

       * little endian reader for 8 byte long.
       */
-    public final long readLELong(byte []byteArray) {
-    return
-    (long)(byteArray[7])      << 56 |  /* long cast needed or shift done 
modulo 32 */
-    (long)(byteArray[6]&0xff) << 48 |
-    (long)(byteArray[5]&0xff) << 40 |
-    (long)(byteArray[4]&0xff) << 32 |
-    (long)(byteArray[3]&0xff) << 24 |
-    (long)(byteArray[2]&0xff) << 16 |
-    (long)(byteArray[1]&0xff) <<  8 |
-    (byteArray[0]&0xff);
+    public final long readLELong(byte[] byteArray) {
+        return (long) (byteArray[7]) << 56 | /* long cast needed or shift done 
modulo 32 */
+               (long) (byteArray[6] & 0xff) << 48 | (long) (byteArray[5] & 0xff) << 40 | (long) 
(byteArray[4] & 0xff) << 32 | (long) (byteArray[3] & 0xff) << 24
+               | (long) (byteArray[2] & 0xff) << 16 | (long) (byteArray[1] & 0xff) 
<< 8 | (byteArray[0] & 0xff);
      }

I agree with your formatting Michael,

But is everybody happy with it, especially the 2n one?

Jacques