Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java RecordIterator.java

[Jacques Le Roux]

Le 28/10/2017 à 16:45, mbr...@apache.org a écrit :

-        for (int i = 0; i < modelField.length; i++)
-            sb.append(PAD_CHAR);
-        data = sb.toString();
-        }
+                for (int i = 0; i < modelField.length; i++)
+                    sb.append(PAD_CHAR);
+                data = sb.toString();
+            }

Hi All,

I find this ambiguous. We have few options here:

1)
                for (int i = 0; i < modelField.length; i++)
                    sb.append(PAD_CHAR);

                data = sb.toString();

2)
                for (int i = 0; i < modelField.length; i++) {
                    sb.append(PAD_CHAR);
                }
                data = sb.toString();

3)
                for (int i = 0; i < modelField.length; i++) sb.append(PAD_CHAR);
                data = sb.toString();

4)
                for (int i = 0; i < modelField.length; i++) sb.append(PAD_CHAR);

                data = sb.toString();

Which one do you prefer? Of course this should be a general rule, not only for 
this case!

Thanks

Jacques