Hi Suraj,

this service seems not to be used anywhere in the system and the code looks... ämm..., strange.

I'd propose to remove it from the codebase along with other resources like the UI labels referenced there (if not used anywhere else).

I think it is worth to have a deeper look at the whole class.

Thanks and regards,

Michael


Am 14.11.17 um 12:09 schrieb Suraj Khurana:
Hello,

While using service *getPartyFromUserLogin *and it is not returning
desired results. While digging more into the issue, I found that the
service is using LIKE operator instead of returning exact records. Is it
intentional or a bug?

IMO, this is not correct and it should return exactly similar records for a
particular party.

Moving further, why it is a service? IMO, it should be a helper method.

Please let me know your thoughts about this.

--
Thanks and Regards,
*Suraj Khurana* | Sr. Enterprise Software Engineer
*HotWax Commerce* by  *HotWax Systems*
Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010



Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to