Thanks Suraj,
I'll take care of the renaming. At 1st glance I don't see a need for other
refactorings, I let you decide on this...
Jacques
Le 15/11/2017 à 09:14, Suraj Khurana a écrit :
Thanks, Jacques and Michael for your inputs,
I agree with both the points, either such services should be removed as
they are not being used and not written properly, or refactoring of the
whole class with proper names as per their functionality to justify their
name.
I am willing to participate in this effort if we are more intended towards
refactoring. Please let me know how we are proceeding in this.
I have created a Jira here
<https://issues.apache.org/jira/browse/OFBIZ-9982>.
--
Thanks and Regards,
*Suraj Khurana* | Sr. Enterprise Software Engineer
*HotWax Commerce* by *HotWax Systems*
Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
On Wed, Nov 15, 2017 at 2:54 AM, Jacques Le Roux <
[email protected]> wrote:
Le 14/11/2017 à 21:39, Michael Brohl a écrit :
Am 14.11.17 um 19:15 schrieb Jacques Le Roux:
I see no reasons to drop those services if some find them useful. I get
they do since someone wrote it, even with a misleading name. Not having
them used OOTB is not a sufficient indication of removal.
I do not agree. This functionality is not used since a decade and the
code is in bad shape.
I think it makes much more sense to put effort in the many other fields
of action we have in this project.
Michael
I can take care of renaming the methods, don't worry
Jacques
