Hello, +1 to follow the 120char guideline for any commit that the purpose it not to refactor line length :).
Gil Le vendredi 26 oct. 2018 à 11:13:48 (+0200), Mathieu Lirzin a écrit : > Hello Jacques, > > Jacques Le Roux <jacques.le.r...@les7arts.com> writes: > > > Yes you are right, the whole file should be reformatted. > > > > This "around 120 chars max" rule is "new" (few years) and most of the > > code there is more than a decade. > > OK, sure. > > > If nobody disagree we could have a task Jira to reformat the code of > > the most important classes (with subtasks maybe, or simply patches for > > concerned classes). > > I sympathise but I am not sure about this strategy, which depending on > the capabilities of your VCS might obscure the commit history. I would > recommend to simply use the “120 chars max” guideline for newly added > code and when refactoring existing one. > > WDYT? > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
