As I said countless times so far, mostly to Jacques, let's please try to avoid the "I have an idea, now let's do it everywhere in the code base" kind of approach. Slow gradual refactoring is the way to go to ensure sustainable quality and stability.
Therefore, I'm in favor of Mathieu's approach. On Fri, Oct 26, 2018 at 12:13 PM Mathieu Lirzin <[email protected]> wrote: > > Hello Jacques, > > Jacques Le Roux <[email protected]> writes: > > > Yes you are right, the whole file should be reformatted. > > > > This "around 120 chars max" rule is "new" (few years) and most of the > > code there is more than a decade. > > OK, sure. > > > If nobody disagree we could have a task Jira to reformat the code of > > the most important classes (with subtasks maybe, or simply patches for > > concerned classes). > > I sympathise but I am not sure about this strategy, which depending on > the capabilities of your VCS might obscure the commit history. I would > recommend to simply use the “120 chars max” guideline for newly added > code and when refactoring existing one. > > WDYT? > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
