The use of separate individual dispatchers/delegators per test suite was introduced at the same time as the delegator rollback/reset code, and was intended to allow for test suites to be run (and data to be reset) in parallel.
The test framework never sees much love though so that never happened. It's difficult to accomplish because many test suites rely on the same underlying demo data. I don't mind either way, just thought the history lesson might be helpful. https://issues.apache.org/jira/browse/OFBIZ-2259 https://markmail.org/thread/zjghmk25bllthxme Regards Scott On Sat, 27 Oct 2018, 22:59 Taher Alkhateeb, <[email protected]> wrote: > Ahh, Now I understand what you mean by looking at your patch. I > recommend next time that you copy-paste into the email thread because > people who try to access this thread using the ML archives might not > see your attachments. > > At a first glance, although this feature is not used in the current > OFBiz code base. it _might_ be used by some users who are running > certain tests against specific tenants for example. So although I > would probably lean towards removing it, I'd recommend making sure > that not many people depend on this feature. Perhaps you can check in > the user ML or wait for others to share their opinions. > On Sun, Oct 21, 2018 at 10:51 PM Mathieu Lirzin > <[email protected]> wrote: > > > > Hello Taher, > > > > Taher Alkhateeb <[email protected]> writes: > > > > > An example could shed some light here perhaps? > > > > What kind of examples would help you? > > > > AIUI It would be for the people using this feature outside of the > > framework to provide examples why we should keep it in. > > > > > What do you want to remove from where? > > > > Here is what I precisely want to remove. > > > > > > > How is it complex? > > > > Basically each time an option is provided it adds complexity. In this > > particular case, perhaps a comparaison between the two models of test > > execution can help describing the added complexity: > > > > Current model: > > 1. Launch OFBiz > > 2. Fetch all the tests from the components > > 3. Keep track which delegator/dispatcher correspond to each test suite > > 4. Run each test by setting its corresponding delegator/dispatcher > > > > Model without option: > > 1. Launch OFBiz with the test delegator/dispatcher > > 2. Fetch all the tests from the components > > 3. Run the tests. > > > > Does it help? > > > > -- > > Mathieu Lirzin > > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 >
