Hello, Michael Brohl <[email protected]> writes:
> Although I appreciate this kind of work, we should definetely commit > in smaller chunks (package or even class level). > > I thought that we agreed upon that. Althought I strongly agree with the choice of making small commits that are easier to review and revert, I don't think it is convenient to apply a huge set of patches submitted via JIRA. Before submitting my 2 patches on OFBIZ-10701 [1], I had 27 local git commits splitted by type of warning. I chose to squash them as a tradeoff between the size of the diff and the number of submitted patches. For casual contributors the number of patches is usually not a issue in practice. However since I am basically working on OFBiz fulltime, If I was providing a patch for each atomic commit I have locally, this would put a lot of burden on the reviewers shoulders. Maybe we could improve our processes to achieve both review scalabity and commit atomicity, but in any case I am grateful to Jacques for the important and useful work he is doing by reviewing other people patches. [1] https://issues.apache.org/jira/browse/OFBIZ-10701 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
