Nicolas Malin <[email protected]> writes: > On 30/05/2019 13:04, Mathieu Lirzin wrote: > >> Nicolas Malin <[email protected]> writes: >> >>> hmm not, I just control that if we haven't gradlew we init it. >>> >>> Your remark just alert me that I forget to set the gradlew on .ignore >> I am confused. Are you proposing to add "gradlew" in the “./gitignore” >> and “./hgignore” files in the framework repository? If not what is >> “.ignore”? > > Tu pinalles Maurice :) > > You right, the better syntax would be ./*ignore so yes complete > ./gitignore and ./hgignore
I wasn't nitpicking on your spelling, I was just checking that I was I was understanding you correctly before disagreeing. :-) IMO “./gradlew” should definitely be kept in our Version Controlled System (VCS) in order to follow Gradle recommendations and avoid specific build instructions. The requirement of not distributing “gradle-wrapper.jar” in OFBiz releases should only impact the build process of the release archives and *not* the build process of the VCS branches. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
