Hello Jacques, Jacques Le Roux <[email protected]> writes:
> Not a big deal (it's only in the commits log), I'm not sure we want stuff > like: > > Le 27/11/2019 à 17:48, [email protected] a écrit : >> Author: Samuel Trégouët<[email protected]> > > Normally we rather use something like > > Thanks to Samuel Tregouet for this fix > > I did not notice yet, we have already 10 of them in Git repo. > > Not sure we want to avoid them, maybe if Samuel has an ICLA it's OK, unsure > on my side... > > I mean is that something Git forces us, or could we prevent it if needed? The fact that Samuel was defined as the author of the commit was a conscient action on my side (i.e. Git do not force us to do so). Since it is a very common practice to commit somebody else work, in Git there is a clear distinction between the author and the committer which can is done with ‘git commit --author="..."’ when both are not the same person. This provides more explicit credits to the actual author without relying on ad-hoc conventions. As I understand it, the practice of committing somebody else work under the committer name (not the author name) and adding credits in the commit log to the actual author was only the result of a limitation of Subversion which does not handle the scenario of committing somebody else work. I didn't bother discuss the usage of this Git feature before hand because I thought it would be obviously accepted by the community, but since it seems not necessarily natural for you (an probably others) I am open to the discussion now. :-) Indeed I am aware that any author should sign an ICLA, I assumed that Samuel have signed but did not actually check. Samuel: have you signed the ICLA ? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
