Whatever the participation and the outcome of this discussion will be... In the past complaints (relating to the subject of labels) have been raised about:
- patches too big (because of too much work to investigate, merges leading to conflicts in local repos), and - patches too small (asking for more work done before willingness to collaborate) Re: tracing the reason why something happened in the past This should not be a requirement (at least for aspects like unused labels typos and whitespace), as it places an burden on the contributor leading to a cost (effort) disproportionate to the benefit. Above that, it will feed the blame-game. Such complaints (and unreasonable requirements) are detrimental to the health of the project, and should not happen. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Thu, Feb 27, 2020 at 1:58 PM Pierre Smits <[email protected]> wrote: > Given that the OFBiz community consists of more than just a handful of > active PMC Members, Committers and other contributors, the question should > *not* just be: Should we clean labels'. > > But rather: Should we welcome contributions that only address the cleaning > of unused labels, and if so get them into the code base? > > The same question can be asked for contributions regarding: > > - typos > - unused code > - whitespace > - etc. > > My answer, for the benefit of the project and the appreciation felt by the > (potential) contributor and adopter, will always be: an unequivocal YES. > Not only for reasons stated above, but also for all other obvious positive > arguments. This should not be about catering to people NOT willing to do > stuff, even if it is not important enough for them or regarded as menial by > them. This is about catering to people willing to do even this kind of > stuff. > > And if there is no-one (among the pool of privileged contributors) willing > to do this kind of work, then the PMC should grant privileges to those > contributors willing to do that, > > Met vriendelijke groet, > > Pierre Smits > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since > 2008 (without privileges) > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > *Apache Directory <https://directory.apache.org>, PMC Member* > Apache Incubator <https://incubator.apache.org>, committer > Apache Steve <https://steve.apache.org>, committer > > > On Thu, Feb 27, 2020 at 12:46 PM Jacques Le Roux < > [email protected]> wrote: > >> Hi, >> >> With OFBIZ-9352 (under OFBIZ-10565) Pierre Smits propose to remove unused >> labels from AccountingUiLabels.xml >> >> This morning I looked at the related PR (17) and, using Label Manager (in >> Webtools) found that there are much more unused labels than those Pierre >> proposes to remove. >> >> I checked the 5 1st ones locally in my IDE and they are indeed unused (no >> references at all but in the label file). >> >> Now we had already a talk with Pierre, Scott and Michael about removing >> labels in OFBIZ-9352. >> >> Scott, Michael, and I in a less measure, are cautious about the reasons >> to remove "unused" labels and you can read in OFBIZ-9352. >> >> To define an unused labels I repeat what I said above: >> >> An unused label is a label reported by the Label Manager as unused that >> can be checked as unused by hand. >> >> As you can see with my answer to Scoot in OFBIZ-9352, more work may be >> needed if we want to trace why a label is unused. >> >> My question, is should we remove unused labels? >> >> And if we do so, which steps should me required: >> >> 1. Label Manager >> 2. Check by hand locally >> 3. Trace the reason >> >> Obviously if we require the 3 steps nobody will do it (will you?). >> >> Even the 2 steps are much work for a little benefit >> >> So what? Should we close Jira issues related to removing unused labels as >> won't do. Should they stay for the "eternity"? >> >> About the Label Manager "unused labels" option, I think it can be still >> useful in custom projects, but, as shown above, tricky OOTB. >> >> Jacques >> >>
