Saying is not proving IMO.The contributor should at least provide information *how* he did the checks along with the patch to help the committer decide. That is very reasonable to ask for.
Low hanging fruits can also be foul. It does not help anyone to commit a patch to remove labels and get one or more Jira bug reports back, reporting missing labels.
Michael ecomify GmbH - www.ecomify.de Am 27.02.20 um 14:42 schrieb Pierre Smits:
Re: IMO this check cannot be burdened upon the committer (if another
contributor provided the patch).The responsibility to thoroughly check if a
removed label is in fact unused should be on the contributor. Which means
he should prove which steps he took to check each removed label [2].
We can all guess what the comment with the patch will be: 'I did the manual
check(s) and I found it only in <foo>Labels.xml'.
What then?
1. Asking for more details? Or screenshots? Or log excerpts?
2. A statement of distrust towards the fellow contributor?
Don't require more than is reasonable for this kind of low hanging fruit.
smime.p7s
Description: S/MIME Cryptographic Signature
