Hi All,
Suraj rightly mentioned that we have no FileLength checkstyle rule and the max
default is 2000 lines:
https://checkstyle.sourceforge.io/config_sizes.html#FileLength
We have some very large Java files in trunk and few (19) are longer than 2000
lines.
The question is should we increase FileLength checkstyle rule to hide the issue
or try to split those files?
I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for that
Jacques
https://checkstyle.sourceforge.io/config_sizes.html#FileLength
Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <suraj.khur...@hotwax.co>
wrote:
Thanks everyone,
Here[1] is the ticket to track this improvement.
[1]: https://issues.apache.org/jira/browse/OFBIZ-11737
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
holivier.li...@ofbizextra.org> wrote:
+1
Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
Hello Devs,
Recently we are facing some checkstyle issues and one cause of it is
LineLength property.
Currently we have set it to 120, I think we should make it to 150
instead.
It is pretty visible in 13/14 font sizes as well.
Please share your thoughts on this.
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
