How many files would violate that 2000-lines rule? Met vriendelijke groet,
Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Tue, May 26, 2020 at 8:11 AM Suraj Khurana <[email protected]> wrote: > +1 for setting rule. Also we can think of some configured values instead of > 2000 (default). may be we should set it to 3000 instead. > > And then as Daniel mentioned, work on refactoring those offending source > files where possible. > > -- > > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Mon, May 25, 2020 at 8:49 PM Carsten Schinzer < > [email protected]> wrote: > > > +1 for setting the max lines rule > > > > > Am 25.05.2020 um 17:05 schrieb Daniel Watford <[email protected]>: > > > > > > Hi Jacques, > > > > > > I would vote for setting an explicit rule to have the max line length > set > > > at 2000 lines and then work on refactoring those offending source files > > > where possible. > > > > > > If we find some files cannot be split up then I think we can add > > exceptions > > > to prevent the max line length rule from being applied to them. But > that > > > should be done on a file by file basis. > > > > > > I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer. > > > Work has been progressing slowly but development has slowed during the > > > pandemic. I hope to get back on top of this soon. > > > > > > Thanks, > > > > > > Dan. > > > > > > On Mon, 25 May 2020 at 15:43, Jacques Le Roux < > > [email protected]> > > > wrote: > > > > > >> Hi All, > > >> > > >> Suraj rightly mentioned that we have no FileLength checkstyle rule and > > the > > >> max default is 2000 lines: > > >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength > > >> > > >> We have some very large Java files in trunk and few (19) are longer > than > > >> 2000 lines. > > >> The question is should we increase FileLength checkstyle rule to hide > > the > > >> issue or try to split those files? > > >> > > >> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for > > that > > >> > > >> Jacques > > >> > > >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength > > >> > > >> Le 25/05/2020 à 15:09, Suraj Khurana a écrit : > > >>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208 > > >>> > > >>> -- > > >>> Best Regards, > > >>> Suraj Khurana > > >>> Senior Technical Consultant > > >>> > > >>> > > >>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana < > [email protected] > > > > > >>> wrote: > > >>> > > >>>> Thanks everyone, > > >>>> > > >>>> Here[1] is the ticket to track this improvement. > > >>>> > > >>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 > > >>>> > > >>>> -- > > >>>> Best Regards, > > >>>> Suraj Khurana > > >>>> Senior Technical Consultant > > >>>> > > >>>> > > >>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < > > >>>> [email protected]> wrote: > > >>>> > > >>>>> +1 > > >>>>> > > >>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit : > > >>>>>> Hello Devs, > > >>>>>> > > >>>>>> Recently we are facing some checkstyle issues and one cause of it > is > > >>>>>> LineLength property. > > >>>>>> Currently we have set it to 120, I think we should make it to 150 > > >>>>> instead. > > >>>>>> It is pretty visible in 13/14 font sizes as well. > > >>>>>> > > >>>>>> Please share your thoughts on this. > > >>>>>> > > >>>>>> -- > > >>>>>> Best Regards, > > >>>>>> Suraj Khurana > > >>>>>> Senior Technical Consultant > > >>>>>> > > >> > > > > > > > > > -- > > > Daniel Watford > > > > >
