Hi Guys,
I have a problem with that. Sorry for the long coming text :)
Initially the gradle-js-plugin was created and published as a Gradle plugin by Eric Wendelin at https://github.com/eriwen/gradle-js-plugin. There is
also https://github.com/eriwen/gradle-css-plugin
There was a good old time when this was available[1]. But with Gradle upgrades
these plugins were slowly abandoned by their creator, eg[2]
Some forks where done, eg[3][4]. Seems that their creators could not get PRs
merged. So I don't know how/if they are published and used.
My concern is that if you want to publish using the "plugin publishing plugin"[5] you need to use a
so called "'group" which is initially "com.eriwen".
The Groovy code is "Licensed under the Apache License, Version 2.0" but also
"Copyright[ed in] 2012 [by] Eric Wendelin"[6]
That would not be a problem I guess, ASL2 should prevail. The concern is about the so called
"'group" to publish to (initially "com.eriwen").
Since Eric Wendelin don't care anymore about PRs, it seems he is blocking publishs on
"com.eriwen".
So I want to change it to "org.apache.ofbiz" to be able to publish. I guess I
also need to change the package names (not yet sure about that)
What I see for other forks is they still use "com.eriwen" in package, eg[7]. So I guess they are not officially published. I'm still unsure I don't
miss anything.
The JavaScript Source Map is a cool thing when you need to get into other minified libs. I must say I never got blocked by not being able to do that.
But I'd have liked to be able to do so few times.
Now we also know (thanks to Suraj) that "We will get source map URL in most of the
libraries except jQuery, we will have to manually add it"[8]
I put an alert about that at
https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js
My questions are:
1. Should we care about JavaScript source maps (I think we should)?
2. Should we care about gradle-js-plugin?
3. If we don't, is my alert in wiki enough (using js tools is uneasy to me)?
Thanks to get to this point ;)
Jacques
[1] https://dzone.com/articles/javascript-webapps-gradle
[2] https://github.com/eriwen/gradle-css-plugin/issues/58
[3] https://github.com/twwwt/gradle-js-plugin
[4] https://github.com/tbutter/gradle-js-plugin/
[5] https://plugins.gradle.org/docs/submit
[6]
https://github.com/eriwen/gradle-js-plugin/blob/master/src/main/groovy/com/eriwen/gradle/js/tasks/CombineJsTask.groovy
[7]
https://github.com/twwwt/gradle-js-plugin/blob/master/src/main/groovy/com/eriwen/gradle/js/tasks/CombineJsTask.groovy
[8] https://github.com/jquery/jquery/issues/4166
Le 24/07/2020 à 15:39, Jacques Le Roux a écrit :
Thanks Aditya,
It works only with 5.1 mine works with 6.3. I want to publish it as org.apache.ofbiz.gradle-js-plugin or maybe simply org.apache.ofbiz.js-plugin.
Still have to complete that (one point is confusing)
Jacques
Le 24/07/2020 à 13:47, Aditya Sharma a écrit :
That's great Jacques.
Just for reference, another fork of gradle js plugin which was updated in
May 2019.
https://plugins.gradle.org/plugin/eu.butter.gradle.js
https://github.com/tbutter/gradle-js-plugin/
Thanks and regards,
Aditya Sharma
On Thu, Jul 23, 2020 at 2:00 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
Hi All,
Backport done, I have created a fork of gradle-js-plugin and it works with
Gradle 6.3. I'll tell you more when I'll get a chance :)
Jacques
Le 19/07/2020 à 16:08, Jacques Le Roux a écrit :
Thanks Aditya,
@All, without more answers I'll exceptionally use a lazy consensus to
backport changes in minified and add of maps files down to R17 in a week
from
"16/07/2020 à 15:01"
This because, even if the Jiras are registered as improvements and we
can't see anything in UI and OFBiz logs, there are 404 and lack of help in
browser log.
Thanks to Alex for the help!
Jacques
Le 17/07/2020 à 14:41, Aditya Sharma a écrit :
Thank you, Jacques and Alex, for bringing this up. I think source maps
can
be a great aid for debugging. I am willing to give a hand.
Thanks and regards,
Aditya Sharma
On Thu, Jul 16, 2020 at 8:36 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
Le 16/07/2020 à 15:01, Jacques Le Roux a écrit :
https://issues.apache.org/jira/issues/?jql=project %3D OFBIZ AND
text ~
"map alex"
This url is easier to use: https://s.apache.org/xzdtx
