Hi Daniel, I indeed see only imports of org.apache.ofbiz.widget.renderer.html under framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html
HtmlMenuWrapper, which uses HtmlMenuRenderer, is used in MenuWrapTransform But I don't see any use of MenuWrapTransform OOTB through menuWrap=org.apache.ofbiz.widget.renderer.MenuWrapTransform I'd go with your WidgetWorker changes if they are trivial in the package ;)
If the HTML Render package is no longer in use can we remove it?
I think it's a good question you asked, it needs more attention. It could be used by (old) custom projects. We can't be dragged down by them eternally... HTH Jacques Le 25/07/2020 à 10:58, Daniel Watford a écrit :
Hello, While working on OFBIZ-11907 ( https://github.com/apache/ofbiz-framework/pull/217) I needed to alter the various callers to WidgetWorker's methods for creating URLs, links and hidden forms. For most of the callers I was able to find examples of their use and therefore (manually) check that current behaviour was maintained after the WidgetWorker changes. However I couldn't find any places where HtmlMenuRenderer and HtmlTreeRenderer were used. I've made minimal changes to HtmlMenuRenderer and HtmlTreeRenderer so they can continue to use WidgetWorker, but without concrete examples of usage I am unable to prove they still work. Is the HTML Renderer package (org.apache.ofbiz.widget.renderer.html) still in use or was it replaced by the Macro Renderer package? If HTML Renderer is still used please please point me at the relevant screens in Ofbiz so I can confirm they have not been broken by the WidgetWorker changes. If the HTML Render package is no longer in use can we remove it? Thanks, Dan.
