Thanks Daniel! Michael Brohl
ecomify GmbH - www.ecomify.de Am 28.07.20 um 17:42 schrieb Daniel Watford:
I did search but couldn't find anything using the HTML renderers. OFBIZ-6281 [1] and its related issues lead me to believe that the package should have been removed a while ago, particularly since HtmlScreenRenderer appears to have been removed. Michael, based on your comments I've created OFBIZ-11927 to deprecate the HTML renderers. [1] - https://issues.apache.org/jira/browse/OFBIZ-6281 [2] - https://issues.apache.org/jira/browse/OFBIZ-11927 On Tue, 28 Jul 2020 at 14:17, Michael Brohl <michael.br...@ecomify.de> wrote:If the package is not used anywhere (havn't checked), we should deprecate and document it for the next release and remove it in the release which comes after the next release. This should give users enough time to change their projects accordingly. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 28.07.20 um 14:55 schrieb Jacques Le Roux:Hi Daniel, I indeed see only imports of org.apache.ofbiz.widget.renderer.html under framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html HtmlMenuWrapper, which uses HtmlMenuRenderer, is used in MenuWrapTransform But I don't see any use of MenuWrapTransform OOTB through menuWrap=org.apache.ofbiz.widget.renderer.MenuWrapTransform I'd go with your WidgetWorker changes if they are trivial in the package ;)If the HTML Render package is no longer in use can we remove it?I think it's a good question you asked, it needs more attention. It could be used by (old) custom projects. We can't be dragged down by them eternally... HTH Jacques Le 25/07/2020 à 10:58, Daniel Watford a écrit :Hello, While working on OFBIZ-11907 ( https://github.com/apache/ofbiz-framework/pull/217) I needed to alter the various callers to WidgetWorker's methods for creating URLs, links and hidden forms. For most of the callers I was able to find examples of their use and therefore (manually) check that current behaviour was maintained after the WidgetWorker changes. However I couldn't find any places where HtmlMenuRenderer and HtmlTreeRenderer were used. I've made minimal changes to HtmlMenuRenderer and HtmlTreeRenderer so they can continue to use WidgetWorker, but without concrete examples of usage I am unable to prove they still work. Is the HTML Renderer package (org.apache.ofbiz.widget.renderer.html) still in use or was it replaced by the Macro Renderer package? If HTML Renderer is still used please please point me at the relevant screens in Ofbiz so I can confirm they have not been broken by the WidgetWorker changes. If the HTML Render package is no longer in use can we remove it? Thanks, Dan.
smime.p7s
Description: S/MIME Cryptographic Signature
