Jacques, Is it worth canceling the vote and starting a new one? Jacopo
On Sun, Dec 19, 2021 at 10:29 AM <jler...@apache.org> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > jleroux pushed a commit to branch release18.12 > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git > > > The following commit(s) were added to refs/heads/release18.12 by this push: > new ddc238a Fixed: Bug in HtmlFormMacroLibrary.ftl::makeHyperlinkString > macro (OFBIZ-12468) > ddc238a is described below > > commit ddc238a49d4b0a58bce91215b6392cd6e32c86f7 > Author: Jacques Le Roux <jacques.le.r...@les7arts.com> > AuthorDate: Sun Dec 19 10:29:21 2021 +0100 > > Fixed: Bug in HtmlFormMacroLibrary.ftl::makeHyperlinkString macro > (OFBIZ-12468) > > Fixes a typo I already fixed in trunk but forgot in demo > --- > themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl > b/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl > index de63a3f..8a6e04e 100644 > --- a/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl > +++ b/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl > @@ -695,7 +695,7 @@ Parameter: delegatorName, String, optional - name of the > delegator in context. > <#macro makeHyperlinkString hiddenFormName imgSrc title alternate linkUrl > description linkStyle="" event="" action="" targetParameters="" > targetWindow="" confirmation="" uniqueItemName="" height="" width="" id=""> > <#if uniqueItemName?has_content> > <#local params = "{"presentation": "layer""> > - <#if targetParameters?has_content && && !targetParameters?is_hash> > + <#if targetParameters?has_content && !targetParameters?is_hash> > <#local parameterMap = targetParameters?eval> > <#local parameterKeys = parameterMap?keys> > <#list parameterKeys as key>