You missed the point of the cited comment on GitHub.
It is not about the PR contents but about a follow-up enhancement for
centralized configuration.
The contributors of the PR themselves (Gil/Marco) want to improve the
PR. I see no reason why you are pushing them to merge a PR they want to
improve first.
It's a better approach to quality than to hurry with a "it works"
attitude and has nothing to do with procrastination.
Michael
Am 03.01.22 um 09:44 schrieb Pierre Smits:
Hi All,
To start with: I wish a healthy and prosperous 2022 to all participating in
this thread.
This works now! It has been brought forward as working as intended and does
not disrupt OFBiz functionality.
While it is good to see that this PR triggers others to think about it and
suggest (potential) variants and/or extensions on the concept, we should
not have that delay making this available to the greater audience.
We don't know what the future may bring regarding improvement following
this PR, those (suggested/promissed) variants and/or extensions. And
suggesting delaying or waiting on somebody else to pen those down (whenever
they may find the time/without any obligation vis-a-vis commitment) does
not help the project.
Stop feeding procrastination.
Met vriendelijke groet,
Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory <https://directory.apache.org>, PMC Member*
On Mon, Jan 3, 2022 at 9:06 AM Michael Brohl <notificati...@github.com>
wrote:
Hi @gilPts <https://github.com/gilPts> ,
we already have such a centralized configuration mechanism in production
for several years now. Maybe we should share this and let him check if it
fits the needs, why do the work again?
—
Reply to this email directly, view it on GitHub
<https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003923835>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6ERMVJ3YE25A3NNOJLQ6TUUFKJBANCNFSM5IYBDP7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
<apache/ofbiz-framework/pull/355/c1003923...@github.com>
