Hi Jacques,

I have restored the mkdir operations you recently removed, mainly for
consistency and to avoid unnecessary dependencies on earlier stages of the
process.

I also removed the rm commands you introduced in the attempt to delete old
files from the nightlies server. Those commands were not actually useful
because they operated only on local files in the BuildBot instance, not on
the remote nightlies files.

Instead, I added the appropriate flag to the rsync step so that files
present on the target but no longer present in the source are automatically
deleted. This is the proper way to achieve what you were trying to do.

Now, after the last successful build, the old files are gone.

Best regards,
Jacopo

On Wed, May 20, 2026 at 7:01 PM Jacques Le Roux via dev <
[email protected]> wrote:

> Hi Jacopo,
>
> It was to clarify the code.
>
> IIRW, I initially simply copied lines from start to end when I needed to
> copy files.
>
> Then, while removing the deprecated files, I thought that the dir
> (trunk|stable|next) is created above in the builder, so there is no need to
> create
> it again. This is true for each builder.
>
> I still don't understand why "rm" is not working. As I mentioned in the
> Jira, it's not the 1st time I cross this issue. I never got an explanation.
> Do
> you have an idea?
>
> Jacques
>
> Le 20/05/2026 à 16:39, Jacopo Cappellato a écrit :
> > Jacques,
> >
> > While reviewing your latest edits to the BuildBot config file I have
> > noticed that you have removed the command "mkdir -p" from various steps
> > (see the example below). What is the reason for this?
> >
> > Regards,
> > Jacopo
> >
> > @@ -254,7 +254,7 @@
> >       f_ofb_trunk_framework_plugins.addStep(
> >           buildbot.plugins.steps.ShellCommand(
> >           name="Copy codenarc to destination directory structure",
> > -            command=["bash", "-c", "mkdir -p trunk && cp -rp
> > build/reports/codenarc/main.html trunk/codenarc.html"],
> > +            command=["bash", "-c", "cp -rp
> > build/reports/codenarc/main.html trunk/codenarc.html"],
> >               description=["Copy codenarc to destination directory
> > structure."],
> >               descriptionDone=["Codenarc copied."],
> >               haltOnFailure=True,
> >
> > On Wed, May 20, 2026 at 12:23 PM Jacques Le Roux via dev <
> > [email protected]> wrote:
> >
> >> Thank you Jacopo,
> >>
> >> I saw you noticed the Infra team in the Jira
> >>
> >> Jacques
> >>
> >> Le 20/05/2026 à 11:04, Jacopo Cappellato a écrit :
> >>> Jacques,
> >>>
> >>> I should be able to fix it by improving the BuildBot config file for
> >> OFBiz.
> >>> We may not need Infra for this.
> >>>
> >>> Jacopo
> >>>
> >>>
> >>> On Wed, May 20, 2026 at 10:25 AM Jacques Le Roux via dev <
> >>> [email protected]> wrote:
> >>>
> >>>> Le 15/05/2026 à 16:29, Jacques Le Roux via dev a écrit :
> >>>>> Also I will remove the root README.html and README.PDF files from
> trunk
> >>>> and stable in nigthlies.
> >>>>> They will no longer be updated while README.md can be on GH.
> >>>> I have created https://issues.apache.org/jira/browse/INFRA-27939 for
> >> that
> >>>> Jacques
> >>>>
> >>>>
>

Reply via email to