Not both, just one had, I have already dealed with that in trunk rev. 605190 and release4.0 rev. 605189
Jacques De : "BJ Freeman" <[EMAIL PROTECTED]> > that does not look like my patch. > mine has an uppcase in it. > > > David E Jones sent the following on 12/18/2007 10:19 AM: > > 1. Bad code formating > > 2. Makes the default true, is that what we really want? > > 3. If 2 is true then should use more compact and easy to read, > > like if != false instead of if = true > > > > -David > > > > > > On Tue, 18 Dec 2007 11:37:55 -0000 > > [EMAIL PROTECTED] wrote: > > > >> Author: jleroux > >> Date: Tue Dec 18 03:37:47 2007 > >> New Revision: 605186 > >> > >> URL: http://svn.apache.org/viewvc?rev=605186&view=rev > >> Log: > >> A patch from BJ Freeman "Allows better testing of testmode from > >> propties file of > >> authorize.net" (https://issues.apache.org/jira/browse/OFBIZ-1450) - > >> OFBIZ-1450 > >> > >> Modified: > >> > >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java > >> > >> Modified: > >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java > >> URL: > >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java?rev=605186&r1=605185&r2=605186&view=diff > >> ============================================================================== > >> --- > >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java > >> (original) +++ > >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java > >> Tue Dec 18 03:37:47 2007 @@ -376,7 +376,15 @@ } private static > >> boolean isTestMode() { > >> - return ("TRUE".equals((String) > >> AIMProperties.get("testReq"))); > >> + boolean ret = true; > >> + String testReq = (String)AIMProperties.get("testReq"); > >> + if(testReq != null) { > >> + if(testReq.equals("TRUE")) > >> + ret = true; > >> + else > >> + ret = false; > >> + } > >> + return ret; > >> } > >> > >> private static String getVersion() { > >> > >> > > > > > > >
