[
https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606001#action_12606001
]
Jacques Le Roux commented on OFBIZ-1427:
----------------------------------------
Some other remarks (I suppose you read
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices)
. Don't put your reference (name or what else) in the patch
. For commentd use simple one
eg
not
//PATCH - importing DeviceLoader for pop.drawer - BSTRICKLAND
but
// importing DeviceLoader for pop.drawer
Imagine if everybody was putting his name in code ;o)
There is a duplicated SaveSale.java part in your patch, not sure how this could
happen. It seems that a Keyboard class is missing i get this when compiling
[javac] ^
[javac]
D:\Workspace\ofbiz.pos\specialpurpose\pos\src\org\ofbiz\pos\screen\SaveSale.java:132:
cannot find symbol
[javac] symbol : class Keyboard
[javac] location: class org.ofbiz.pos.screen.SaveSale
[javac] Keyboard keyboard = new Keyboard(m_pos);
[javac] ^
[javac]
D:\Workspace\ofbiz.pos\specialpurpose\pos\src\org\ofbiz\pos\screen\SaveSale.java:132:
cannot find symbol
[javac] symbol : class Keyboard
[javac] location: class org.ofbiz.pos.screen.SaveSale
[javac] Keyboard keyboard = new Keyboard(m_pos);
[javac] ^
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 2 errors
[javac] 7 warnings
BUILD FAILED
D:\Workspace\ofbiz.pos\build.xml:131: The following error occurred while
executing this line:
Moreover, there is already a Keyboard class but without a one parameter
constructor.
Thanks for your work
> Modal windows require keyboard and mouse
> ----------------------------------------
>
> Key: OFBIZ-1427
> URL: https://issues.apache.org/jira/browse/OFBIZ-1427
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Environment: Any
> Reporter: Vince Clark
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: keyboard.diff
>
>
> Modal windows such as "Cash Out" require the use of a keyboard and mouse to
> enter data because the keypad cannot be accessed for input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
