[ 
https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607787#action_12607787
 ] 

Jacques Le Roux commented on OFBIZ-1427:
----------------------------------------

Branden, Chris,

First of all bravo ! 

Just some minor remarks, 
. please, don't forget to put ASL2 header at top of new files;
. don't use tabs in your code but 4 spaces;
. take care of your way of formatting code. Please when you will have a chance 
read carefully http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html. 
This link cand be found in red in 
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices ;o).
. Have a look at revision 671332 commit to see how I modified code from your 
patch.

Thanks and keep on the good work



> Modal windows require keyboard and mouse
> ----------------------------------------
>
>                 Key: OFBIZ-1427
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1427
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff
>
>
> Modal windows such as "Cash Out" require the use of a keyboard and mouse to 
> enter data because the keypad cannot be accessed for input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to