[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619936#action_12619936
]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
I have already spent a considerable amount of time thinking about user
preference settings. I had them implemented where I work years before their
introduction to the project. Maybe you aren't understanding how they are
intended to to be used.
The "_NA_" user login ID found in User Preferences is intended to be used when
the user isn't logged into OFBiz (or they are logged in and no preference has
been set) and some sort of default values must be supplied. Doing things this
way simplifies the code using the preferences - instead of always checking to
see if a preference exists, you can assume it exists because the preference
data was set up that way. Doing things this way also provides a single point
where a particular default value can be changed.
In the trunk there is only one global preference implemented - a flag to
indicate if the user has JavaScript enabled. (A global preference is a
preference that is used by more than one component.) Once the visual theme
feature is implemented there will be two global preferences. In a few months
there might be more. As time goes on and more global preferences are
implemented, it will be easy to have one service call to get them all - by
retrieving the GLOBAL_PREFERENCES group. (I'm picturing the global preferences
being retrieved by the view handler at the start of view processing. I might
even add that change to this issue - I'm still thinking about it.)
I believe this process is fundamentally sound and easy for developers to
understand. What will cause confusion is when a property and a bit of code
changes the behavior of a particular preference.
If an installation wants to have a different default theme, then they will only
have to overwrite the "_NA_" user login preference record with their own data.
One thing we can change to help avoid confusion is the description of the OFBiz
default theme. Maybe call it "Standard OFBiz - Floating" or "Original OFBiz -
Floating", etc.
I would prefer to start off with a simple implementation and see how it goes.
If switching default visual themes becomes an issue down the road, then we can
address it at that time.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip,
> visual_themes.patch, visual_themes.patch, visualtheme_merged.patch,
> visualtheme_merged.patch, VisualThemeSelection.patch,
> VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable
> Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
