This is the meaning of my last message. Jacopo
On Aug 31, 2008, at 11:12 PM, Adrian Crum wrote:
Jacopo,Right now an extended form widget will use the parent form's actions, and if the extended form has actions, those actions *replace* the parent form's actions.I can see where that behavior might be expected or wanted, but I can also see where you would want the extended form's actions *added* to the parent form's actions.So, I guess we need to decide what is the correct behavior with extending form widget actions.-Adrian--- On Sun, 8/31/08, Jacopo Cappellato <[EMAIL PROTECTED]> wrote:From: Jacopo Cappellato <[EMAIL PROTECTED]>Subject: Re: Adding actions instead of replacing them in extended formsTo: [email protected] Date: Sunday, August 31, 2008, 10:26 AM Adrian, if we go this route, we have to check if there are existing forms (that extend another form) that could be affected by this change. Cheers Jacopo On Aug 31, 2008, at 10:44 PM, Adrian Crum wrote:Forwarding this to the dev list for comment... --- On Sun, 8/31/08, Adrian Crum<[EMAIL PROTECTED]> wrote:From: Adrian Crum <[EMAIL PROTECTED]> Subject: Re: Adding actions instead of replacingthem in extendedforms To: [EMAIL PROTECTED] Date: Sunday, August 31, 2008, 10:01 AM I can make the change now to have the form widgetsimplyextend the parent form's actions. (It seems tome thisis what was intended, but somehow it gotoverlooked in thejava code.) If you would like to see additional abilitiesadded to theform widget, then we will have to wait for othersto offertheir comments. -Adrian --- On Sun, 8/31/08, Bruno Busco <[EMAIL PROTECTED]> wrote:From: Bruno Busco<[EMAIL PROTECTED]>Subject: Re: Adding actions instead ofreplacing themin extended formsTo: [EMAIL PROTECTED] Date: Sunday, August 31, 2008, 9:43 AM Adrian, this pattern is not flexible enough why do nottry togetit more powerfull? In the example application you can find: <form name="EditExampleExt" extends="EditExample"extends-resource="component://example/widget/example/ExampleForms.xml"><!-- NOTE: add new fields for theEditExampleform here --> <field name="exampleText"><display description="This example text means we are in the extendedform."/></field><!-- In order for these to be at thebottomofthe form, we need to hide the buttons from the original form, and then create newones.Wecould use the sort-order element, but that doesn't work well when we wanttoallowchanges in the original form. --> <field name="submitButton"use-when="example!=null"><hidden/></field><field name="submitButton"use-when="example==null"><hidden/></field><fieldname="submitButtonOvrd"title="${uiLabelMap.CommonCreate}" use-when="example==null"widget-style="smallSubmit"><submitbutton-type="button"/></field><fieldname="submitButtonOvrd"title="${uiLabelMap.CommonUpdate}" use-when="example!=null"widget-style="smallSubmit"><submitbutton-type="button"/></field></form> From the comment I can see that the extendingsystemneedto be improved for the field adding also. -Bruno 2008/8/31 Adrian Crum<[EMAIL PROTECTED]>I don't like that idea. The pattern inotherthings like this is somethinglike "I want all of this widget'sactions,plus I want to add theseactions." -Adrian --- On Sun, 8/31/08, Bruno Busco<[EMAIL PROTECTED]> wrote:From: Bruno Busco<[EMAIL PROTECTED]>Subject: Re: Adding actions instead ofreplacingthem in extended formsTo: [EMAIL PROTECTED],[EMAIL PROTECTED]Date: Sunday, August 31, 2008, 9:23 AM I would suggest to implement somethinglikea tag(i.e.<call-parent-actions>) that willlettocall theparent actions like this: <form name"formP"> <actions> <action1> <action2> </actions> </form> <form name"formC" extends="formP"> <actions> <actionA> <call-parent-actions> <actionB> </actions> </form> In this way the user can have parentformactionsexecutedbefore or after the child actions. It will be alsopossibletohave themNOT executed if the <call-parent-actions> tag is notincluded.-Bruno 2008/8/31 Adrian Crum<[EMAIL PROTECTED]>That's interesting - the menuwidgetextendsactions, but the form widgetreplaces them. Having the form widget extendactionswouldbe asimple change to make.Any objections? -Adrian --- On Sun, 8/31/08, Bruno Busco<[EMAIL PROTECTED]> wrote:From: Bruno Busco<[EMAIL PROTECTED]>Subject: Adding actionsinstead ofreplacing themin extended formsTo: [EMAIL PROTECTED] Date: Sunday, August 31, 2008,2:08 AMHi, when extending a form is thereaway toADDactions to theones defined in the original form? What I see now is that actionsdefinedin theoriginal formare completely replaced by the actionsdefined intheextendedform.Thank you, -Bruno
smime.p7s
Description: S/MIME cryptographic signature
