Adam,I appreciate your efforts in the recent commits to clean up test case and its relative code. I am happy now people are getting off sleep and want to contribute to this important part of the OFBiz.
So just you know, almost every test case in accounting require certain pre-condition that need to fulfilled before a test case actually run. They can be in any various form like either running the pre-condition manually, step by step from the OFBiz UI or through defining a demo data (this is the best way to go with).
To make it clear, every test case was committed after it WORKS. AFAIK, Most of the issues relative to JUnit test case are now closed.We were working on in improving JUnit test case some time back so that they run successfully and independent of each other, for that we need to define big pile of demo data. In that direction, there are certain patches uploaded to improve them and the recent patches contain the demo data.
But unfortunately these are uploaded on closed issue. I wasn't have time to look into them and fix them (priorities).
I hope now you can take on some issues. Vikas On Mar 5, 2009, at 8:36 AM, Adam Heath wrote:
I've been doing a bit of test case work the past day. While doing this, I came across a very bad pattern. There were test cases committed to ofbiz, that *never* worked. If you are going to write a test case, or commit a patch that includes a test case, make 100% absolutely certain without a doubt this is an ultimatum that the test case *WORKS*. All of the accounting test cases failed when they were initially checked in. They modified entities that *DID NOT EXIST* in any seed/demo data. This is just so very bad. I'm having to go back thru and *reopen* the bugs that contained these test cases. ps: I'm very frustrated by this. If you don't understand something, then do *not* commit it. Please. With sugar on top.
smime.p7s
Description: S/MIME cryptographic signature
