Vikas Mayur wrote:

> I appreciate your efforts in the recent commits to clean up test case
> and its relative code. I am happy now people are getting off sleep and
> want to contribute to this important part of the OFBiz.
> 
> So just you know,  almost every test case in accounting require certain
> pre-condition that need to fulfilled before a test case actually run.
> They can be in any various form like either running the pre-condition
> manually, step by step from the OFBiz UI or through defining a demo data
> (this is the best way to go with).

If it requires a pre-condition, then it's not a test case, and is just
some code that does something.

Test-cases are supposed to be *automated*.

> To make it clear, every test case was committed after it WORKS.

How did it work?  I reverted back to 660193, the last patch for
OFBIZ-1790, and the accounting tests failed.

If they worked in the past, I'd like to know when.  If so, then that
means something since then has caused them to break, and I will more
than gladly track that down.

However, if they have never worked(which is what I'm strongly
suspecting), then I stand by my original assessment.


Reply via email to