Re: svn commit: r751220 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java

[Jacques Le Roux]

I agree, hopefully Hans will read you :o)
http://svn.apache.org/viewvc?view=rev&revision=745434

Jacques

From: "Adam Heath" <doo...@brainfood.com>

jler...@apache.org wrote:

Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java

URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java?rev=751220&r1=751219&r2=751220&view=diff

==============================================================================
--- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java 
(original)
+++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java Sat Mar 
 7 08:12:32 2009
@@ -110,7 +110,7 @@

             writer.append('>');

-            if(UtilValidate.isNotEmpty(request.getAttribute("image"))){
+            if (UtilValidate.isNotEmpty(request.getAttribute("image"))){
                 writer.append("<img src = 
\""+request.getAttribute("image").toString()+"\"/>");
             }

This is unrelated, but doing StringBuilder.append("abc"+123) is wrong.
You get double StringBuilder instantations.

Also, the spaces around the = in the html should be removed.