Wouldn't that create two String instances, then pass the final String result to StringBuilder.append()?
-Adrian --- On Sat, 3/7/09, Adam Heath <[email protected]> wrote: > From: Adam Heath <[email protected]> > Subject: Re: svn commit: r751220 - > /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java > To: [email protected] > Date: Saturday, March 7, 2009, 9:39 AM > [email protected] wrote: > > Modified: > ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java > > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java?rev=751220&r1=751219&r2=751220&view=diff > > > ============================================================================== > > --- > ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java > (original) > > +++ > ofbiz/trunk/framework/widget/src/org/ofbiz/widget/WidgetWorker.java > Sat Mar 7 08:12:32 2009 > > @@ -110,7 +110,7 @@ > > > > writer.append('>'); > > > > - > if(UtilValidate.isNotEmpty(request.getAttribute("image"))){ > > + if > (UtilValidate.isNotEmpty(request.getAttribute("image"))){ > > writer.append("<img src = > \""+request.getAttribute("image").toString()+"\"/>"); > > } > > This is unrelated, but doing > StringBuilder.append("abc"+123) is wrong. > You get double StringBuilder instantations. > > Also, the spaces around the = in the html should be > removed.
