Code and commit logs are totally separate things. All commit logs have a record of the committer, and if the committer didn't write ALL of the changes in the commit then whoever did should be mentioned in the commit log. In fact, IMO, it is very important that whoever contributed to it be mentioned in the commit log for both legal and attribution/credit reasons.

-David


On Sep 17, 2009, at 9:55 AM, Jacques Le Roux wrote:

I don't agree, we should not have any mention of authors or sponcors in the code, and svn log is IMO part of the code. I belmieve it's more a convention. If I'm not wrong, there are no strict rules about that at the ASF, but it's a convention. I remember Jacopo (and at least I) removing authors references when we went to the incubator.

Jacques

From: "Anil Patel" <[email protected]>
Scott,
Thanks for bringing this up.

This is new way of advertising, may be we should start doing it :)

Regards
Anil Patel
HotWax Media Inc
http://www.hotwaxmedia.com


On Sep 17, 2009, at 8:24 AM, Scott Gray wrote:

Hi Hans,

I'm worried you're creating a precedence here by attributing a commit to your company within the commit message, OFBiz is business software and of course a large majority of the commits are funded by various companies.

Personally I don't think this a practice that we would want to see continued.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 17/09/2009, at 7:43 PM, [email protected] wrote:

Author: hansbak
Date: Thu Sep 17 07:43:05 2009
New Revision: 816083

URL: http://svn.apache.org/viewvc?rev=816083&view=rev
Log:
added a 'setup' component to create a system from seed data only. After the required data is created with this component it is possible to enter a salesorder and quickship it and create an invoice successfully. The 'setup' component will only show in the tab selection if there is no accounting organization. Check the ofbiz document for more info or look in the file applications/ commonext/documents/Setup.xml. Created and sponsored by Antwebsystems. Programmed by employee Tukkata





Reply via email to