It's fine - if this is what the project wants to do and is the practice that vendors should do, then so be it. I would much rather NO mention of companies be on the commit messages - just the people involved - since companies are not committers - only the actual people are.

I'm happy to do it whichever way we decide as a community. Thanks for bringing it up Scott as I thought it was a difference from the norm as well. Hans, thanks for helping push the envelope so that the community can decide what to do.

For now, I'm assuming this means that when we commit things, we could / should be putting our company information there directly. If I've misunderstood this, please let me know - but I'm happy to oblige with the community direction.

Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Sep 17, 2009, at 4:06 PM, Scott Gray wrote:

Well whatever, I just would have preferred to not to see it every in log which is what could very well happen once the ball gets rolling. I'm not saying it's the end of the world, I'm just saying I would have preferred to keep things the way they are now.

Regards
Scott

On 18/09/2009, at 6:17 AM, David E Jones wrote:


If that becomes a problem then we can address it, but that isn't what is happening here.

In a very real way commit logs ARE commercials. If tastefully done they are effective to. If done in a tacky or flamboyant way, chances are people won't appreciate it much.

-David


On Sep 17, 2009, at 12:13 PM, Adrian Crum wrote:

I don't see a problem with attribution either. On the other hand, I can see a potential for the commit logs being turned into commercials:

"XYZ feature added by ABC Systems, Inc - the premier Open For Business solution provider. Contact us at..."

or something like that.

-Adrian

David E Jones wrote:
Maybe I'm funny in the head today, but I don't see any problem with this. Attribution to persons is important, and I'd say even mandatory, and by the pattern established with the individual and company contributor license agreements I have no issue with attribution to employers of contributors if the individual was paid to create something. Attribution is one of the motives people and companies have for working on this software and contributing to the project, so I would NEVER complain because a person took credit for work they did or a company took credit for work they sponsored.
-David
On Sep 17, 2009, at 6:24 AM, Scott Gray wrote:
Hi Hans,

I'm worried you're creating a precedence here by attributing a commit to your company within the commit message, OFBiz is business software and of course a large majority of the commits are funded by various companies.

Personally I don't think this a practice that we would want to see continued.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 17/09/2009, at 7:43 PM, [email protected] wrote:

Author: hansbak
Date: Thu Sep 17 07:43:05 2009
New Revision: 816083

URL: http://svn.apache.org/viewvc?rev=816083&view=rev
Log:
added a 'setup' component to create a system from seed data only. After the required data is created with this component it is possible to enter a salesorder and quickship it and create an invoice successfully. The 'setup' component will only show in the tab selection if there is no accounting organization. Check the ofbiz document for more info or look in the file applications/commonext/documents/Setup.xml. Created and sponsored by Antwebsystems. Programmed by employee Tukkata





Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to