Hi Anil, This workflow is good for independent contributors.
However I employ people who get tasks assigned by me and are working under my responsibility. I try to review the results as good as I can and if there are comments from other committers i will accommodate these as good as I can. However in this case with a average commit rate of 3 commits per day , creating jira issues would be a big overhead with no benefit. Regards, Hans On Wed, 2009-09-30 at 06:59 -0400, Anil Patel wrote: > Hans, > Apache (and Ofbiz) has a workflow defined for contributions coming > from non committers. I am sure you are aware of the process as well. I > will be much more happy if > 1) Contributor create a Jira issue. > 2) In Jira issues Contributor can mention all about company they work > for etc. > 3) Contributor uploads patch to Jira issue > 4) Committer take the patch and applies it. > > Once in a while its fine if committer take contribution directly from > a well established contributor and commits it. I don't think its good > idea to make it a practice. > > I know in community driven projects most of practices is > recommendation and not many rules. Its good if community members > assume recommendations are rules to live by else community can become > difficult place to live in. > > I personally don't see reason why you still want to add company name > in commit log. > > Regards > Anil Patel > > Begin forwarded message: > > > From: [email protected] > > Date: September 30, 2009 5:51:01 AM EDT > > To: [email protected] > > Subject: svn commit: r820232 - in /ofbiz/trunk/framework: common/ > > webcommon/portal/showPortalPage.ftl widget/src/org/ofbiz/widget/ > > WidgetWorker.java widget/src/org/ofbiz/widget/form/ModelForm.java > > widget/src/org/ofbiz/widget/screen/ScreenRenderer.java > > Reply-To: [email protected] > > > > Author: hansbak > > Date: Wed Sep 30 09:51:01 2009 > > New Revision: 820232 > > > > URL: http://svn.apache.org/viewvc?rev=820232&view=rev > > Log: > > fix for OFBIZ-2414: if a portlet is included more than once the > > links do not work, this fix will make these links unique. Sponsored > > By Antwebsystems Co.Ltd: employee Berm > -- Antwebsystems.com: Quality OFBiz services for competitive rates
