+1 -- Regards Ashish Vijaywargiya HotWax Media Pvt. Ltd. http://www.hotwaxmedia.com
Helping hand around the World ... USA | Italy | New Zealand | India Tim Ruppert wrote:
Definitely do them for framework - and really think about the fact that all of the other committers are asking you to use the full process in integrating your changes and your employees changes into the project. We all do it because it's better for the community, so please consider upgrading your support to this best practice as soon as possible, Hans.Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 30, 2009, at 10:00 PM, Hans Bakker wrote:Good suggestion from Scott, i will create jira issues for for framework changes. Regards, Hans On Wed, 2009-09-30 at 20:44 -0600, David E Jones wrote:Hans, If I remember right Anil was in a similar position a couple of years ago. At the time I recommended that for Hotwax we have everyone get a Jira account and submit changes there, and that is what Anil is recommending to you now. There are a few potential benefits to you: 1. happier employees: they get a chance to work directly with the community (as much as they want to and are able, it's not really required to go this way) and get to know people more and become more comfortable with interactive with others 2. more committers: with your people more involved they may soon become committers themselves 3. more reviewers: other committers and other OFBiz users can take a look at what they've done; you don't have to take on the entire burden yourself, or be pushed into a defensive position if there is an issue with one of their commits I remember walking in the streets of a beachside town in Thailand a few years ago and a wise man said to me something along the lines of it always being better to let someone else do something, and help them as needed, than to do it all yourself. I'll admit that hasn't always worked out for me, but I do still think it's good advice. -David On Sep 30, 2009, at 8:07 PM, Hans Bakker wrote:Hi Anil, This workflow is good for independent contributors. However I employ people who get tasks assigned by me and are working under my responsibility. I try to review the results as good as I can and if there are comments from other committers i will accommodate these as good as I can. However in this case with a average commit rate of 3 commits per day , creating jira issues would be a big overhead with no benefit. Regards, Hans On Wed, 2009-09-30 at 06:59 -0400, Anil Patel wrote:Hans, Apache (and Ofbiz) has a workflow defined for contributions coming from non committers. I am sure you are aware of the process as well. I will be much more happy if 1) Contributor create a Jira issue. 2) In Jira issues Contributor can mention all about company they work for etc. 3) Contributor uploads patch to Jira issue 4) Committer take the patch and applies it. Once in a while its fine if committer take contribution directly from a well established contributor and commits it. I don't think its good idea to make it a practice. I know in community driven projects most of practices is recommendation and not many rules. Its good if community members assume recommendations are rules to live by else community can become difficult place to live in. I personally don't see reason why you still want to add company name in commit log. Regards Anil Patel Begin forwarded message:From: [email protected] Date: September 30, 2009 5:51:01 AM EDT To: [email protected] Subject: svn commit: r820232 - in /ofbiz/trunk/framework: common/ webcommon/portal/showPortalPage.ftl widget/src/org/ofbiz/widget/ WidgetWorker.java widget/src/org/ofbiz/widget/form/ModelForm.java widget/src/org/ofbiz/widget/screen/ScreenRenderer.java Reply-To: [email protected] Author: hansbak Date: Wed Sep 30 09:51:01 2009 New Revision: 820232 URL: http://svn.apache.org/viewvc?rev=820232&view=rev Log: fix for OFBIZ-2414: if a portlet is included more than once the links do not work, this fix will make these links unique. Sponsored By Antwebsystems Co.Ltd: employee Berm-- Antwebsystems.com: Quality OFBiz services for competitive rates-- Antwebsystems.com: Quality OFBiz services for competitive rates
smime.p7s
Description: S/MIME Cryptographic Signature
