Adam, Thank you for your comments, please give some more? I realize that technically there are a number of things wrong with this implementation, therefore the branch.
This function however is very useful for reporting purposes what is a pretty weak point in OFBiz, that is why i still committed it. As you suggest we will move it as a separate component in framework and I will not commit it to OFBiz unless you approve it :-) Regards, Hans On Tue, 2009-10-20 at 11:28 -0500, Adam Heath wrote: > Adam Heath wrote: > > [email protected] wrote: > >> Author: hansbak > >> Date: Thu Oct 15 04:48:28 2009 > >> New Revision: 825391 > >> > >> URL: http://svn.apache.org/viewvc?rev=825391&view=rev > >> Log: > >> Add the birt files and reportengine > >> ........ > > > > Bah, very very very wrong. > > > > Do not put shareable things in a WEB-INF. There are *WAY* to many > > things in webtools webapp folder. Remove t hem from there, make them > > global and shareable, and make this a separate component. > > > > This is so wrong, geez. Think, people. > > > > And yes, I am *VERY* annoyed at this, *EXTREMELY*. > > > > *ANYTHING* that goes into ofbiz, to be used by *everyone*, *must* be > > usable by *everyone*. This is only usable by webtools. So, fix it. > > Ok, sorry, not so bad just yet. > > I see this is in a branch, not in trunk. > > However, I will bitch, throw a hissy fit, moan, kill people, if these > files ever get added to trunk in there current layout. There are > *TONS* of duplicated libs, and *TONS* of snapshot files. I would have > never even checked this in, not even into a branch, in this current form. > > > > -- Antwebsystems.com: Quality OFBiz services for competitive rates
