Hans Bakker wrote: > Adam, > > Thank you for your comments, please give some more? I realize that > technically there are a number of things wrong with this implementation, > therefore the branch. > > This function however is very useful for reporting purposes what is a > pretty weak point in OFBiz, that is why i still committed it. > > As you suggest we will move it as a separate component in framework and > I will not commit it to OFBiz unless you approve it :-)
ps: I haven't read the rest of the mails in this thread, so sorry if I repeat something. It appears to be, that this checkin was done by unpacking a zip or tarball, then adding it directly, with no thought about how files should be layed out, according to ofbiz policy. There are duplicate libraries just in this new set of files, let alone duplicates with other libraries that ofbiz already contains. What are the licensing issues with all these libraries? I have no idea what birt is, nor do I need to know. Just based on this size of this checkin, I know it would be useful to have it available for everything/everyone to use. Placing it inside webtools is not how to do that.
