[
https://issues.apache.org/jira/browse/OFBIZ-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768574#action_12768574
]
Abdullah Shaikh commented on OFBIZ-3071:
----------------------------------------
Yes the records with overlapping dates has good reasons I was not aware of, got
something new learned.
But still I guess,
1) If thruDate is not specified, the record goes forever, and we shouldn't
allow one more record.
2) If thruDate specified, then I guess the overlapping should be limited to a
limited time, what I mean is, the next overlapping records fromDate should be
validate to be a month or so, before the thruDate of the previous record.
For example :
I have added PROJECTUSER group to a specific user, the fromDate & thruDate of
first record was 2007-10-10 10:55:10.000 & 2009-10-02 10:55:26.000
respectively, and then I added one more record, with fromDate & thruDate to be
2007-11-10 10:55:10.000 & 2009-10-02 10:55:26.000 respectively.
In this case the validation should have been that,
1) The fromDate of second record can be maximum of a month before the thruDate
of the previous record.
2) The thruDate of the second record should be more than that of the previous
record, bcoz I guess no point in having same thruDate
I couldn't look for more scenarios because of time constraint, but I would
definitely do it when time permits.
Please let me know if this makes sense or if you have some other scenarios or
ideas, I would be happy to makes changes to the patch and resubmit.
> assigning security group to a party without validations
> -------------------------------------------------------
>
> Key: OFBIZ-3071
> URL: https://issues.apache.org/jira/browse/OFBIZ-3071
> Project: OFBiz
> Issue Type: Bug
> Reporter: Abdullah Shaikh
> Priority: Minor
> Attachments: OFBIZ-3071_assigning security group to a party without
> validations.patch
>
>
> When adding user login to Security Group, the fromDate & thruDate input
> fields are not mandatory, if not specified the fromDate is set to current
> timestamop and thruDate is entered in database as null, which means the user
> login is assigned that Security Group forever, but when if the same Security
> Group is added, it again adds it, but instead it should check that if the
> thruDate is null in the already entered record then shouldn't add new record.
> If incase the thruDate is specified during the creation of 1st record then
> while adding the 2nd record for the same Security Group, it should check if
> the thruDate of previous record is before the fromDate of the new record,
> this check also doesn't happen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
