[ 
https://issues.apache.org/jira/browse/OFBIZ-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777427#action_12777427
 ] 

Abdullah Shaikh commented on OFBIZ-3071:
----------------------------------------

Hmm.. yes I agree with David's explanation but there were some doubts in my 
mind, but I couldn't recollect them as its been a long time I opened this issue.

But the doubt I remember is regarding the permission without thruDate, I 
couldn't understand "you could not create a temporary permission for a limited 
span of time", I guess if its a temporary permission it should be for a limited 
time.

Let me modify my example as per my argument regarding thruDate:

2007-10-10 10:55:10.000 & NO THRU DATE
2007-11-10 10:55:10.000 & NO THRU DATE

In the above example the first permission 2007-10-10 as been specified without 
thruDate this means the records will go on forever.
The second permission 2007-11-10 also doesn't have thruDate and this too will 
go on forever.

So as per the above scenario both the permissions will go on forever, for the 
same thing there are 2 permissions.

What I feel is we shouldn't allow the user to enter one more record without 
thruDate for the same permission type as no use of the second record.

If the second record is enter with thruDate then it makes sense as it will 
expire on the mentioned thruDate and the record without thruDate will be active.

I don't know if this is making sense, I mean this was what I was having in 
mind. Maybe I am missing something else.

Let me know what do you think of this.

> assigning security group to a party without validations
> -------------------------------------------------------
>
>                 Key: OFBIZ-3071
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3071
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Abdullah Shaikh
>            Priority: Minor
>         Attachments: OFBIZ-3071_assigning security group to a party without 
> validations.patch
>
>
> When adding user login to Security Group, the fromDate & thruDate input 
> fields are not mandatory, if not specified the fromDate is set to current 
> timestamop and thruDate is entered in database as null, which means the user 
> login is assigned that Security Group forever, but when if the same Security 
> Group is added, it again adds it, but instead it should check that if the 
> thruDate is null in the already entered record then shouldn't add new record.
> If incase the thruDate is specified during the creation of 1st record then 
> while adding the 2nd record for the same Security Group, it should check if 
> the thruDate of previous record is before the fromDate of the new record, 
> this check also doesn't happen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to