Phil Steitz has fixed it in DBCP at r835956
I will give a try, but it's not a reason to not argument about 1.5 vs 1.6 ;o)
Thanks
Jacques
From: "Jacques Le Roux" <[email protected]>
Hi Scott,
FYI, I have asked about it on [email protected] ...
BTW, I can't remember the reasons why we stay to 1.5, are they still valid ?
Jacques
From: "Scott Gray" <[email protected]>
I think Jacques is right about the current source code, there are a
few minor issues that make it 1.6 only. I made some changes and got
it to compile, I'll give it a test run and see how it goes.
Regards
Scott
On 14/11/2009, at 12:00 AM, Jacopo Cappellato wrote:
Hmm... yes you are right, Jacques, sorry for that.
I will try to find out more information...
Jacopo
On Nov 13, 2009, at 11:49 AM, Jacques Le Roux wrote:
Thanks Jacopo,
These are really old ones or do I miss something ?
Jacques
From: "Jacopo Cappellato" <[email protected]>
http://people.apache.org/builds/commons/nightly/commons-dbcp/
Jacopo
On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:
Hi Scott,
At which date was done this nightly build ? Where did you find it ?
BTW I have reverted both trunk and 9.04
Jacques
From: "Scott Gray" <[email protected]>
BTW, the latest nightly build from dbcp works just fine on 1.5
for me, why are you trying to compile dbcp?
Regards
Scott
On 13/11/2009, at 10:36 PM, Scott Gray wrote:
I'd suggest that you revert it for now.
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:
I not totally sure but yet it seems that new versions of DBCP
needs the 1.6 jdk (or jdk 1.4) . Extract from README.TXT :
<<This release of JDBC compiles with and supports JDK 1.3
(JDBC 2.0), JDK 1.4-1.5 (JDBC 3.0) and JDK 1.6 (JDBC 4.0). >>
I tried to build with 1.5 but it failed and I began to find a
way out, not obvious...
So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz
I would not like to push now for the 2d solution but as this
upgrade was intended to fix a bug, I wonder if it's not the
right time
In the meantime (before a decision is taken), I will continue
to search a solution to compile with 1.5 but does not seem
easy (conditional ANT compile deal with JDBC versions), and
I'd not like to rewrite DBCP, even a part, I've other fish to
fry ;o)
Jacques
From: "Jacques Le Roux" <[email protected]>
Thanks Adrian,
Yes I did not care and build with ant from Eclipse where I
use the 1.6 JDK. I'm on it, not as simple as I thought some
problem
appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any
blocking reasons I don't remember ?
Jacques
From: "Adrian Crum" <[email protected]>
Latest trunk:
Compiling 129 source files to C:\ofbiz\framework\entity
\build \classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity
\connection\DBCPConnectionFactory.java:21: cannot access
org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-20091111-
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)
[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the
correct subdirectory of the classpath.
[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15] ^
[javac15] 1 error
