Adam Heath wrote: > Jacopo Cappellato wrote: >> On Mar 17, 2010, at 8:03 PM, Adam Heath wrote: >> >>> [email protected] wrote: >>>> Author: jacopoc >>>> Date: Sat Jan 2 18:20:19 2010 >>>> New Revision: 895250 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=895250&view=rev >>>> Log: >>>> Pretty important change in the way purchase shipments and >>>> purchase-order-to-shipment mapping are modeled: >>>> * OrderShipment entity (that was mostly unused) has been enhanced to >>>> properly associate order items (OrderItemShipGrpAssoc) to shipment items: >>>> this entity is now used in place of ItemIssuance (that was improperly >>>> used, in po, for the same purpose) >>>> * as a consequence of the above change, I have updated the purchase order >>>> receive screens and business logic triggered by them >>>> >>>> Modified: >>>> ofbiz/trunk/applications/order/entitydef/entitymodel.xml >>>> ofbiz/trunk/applications/product/entitydef/entitymodel_shipment.xml >>>> >>>> ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml >>>> >>>> ofbiz/trunk/applications/product/script/org/ofbiz/shipment/receipt/ShipmentReceiptServices.xml >>>> >>>> ofbiz/trunk/applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml >>>> ofbiz/trunk/applications/product/servicedef/services_shipment.xml >>>> >>>> ofbiz/trunk/applications/product/webapp/facility/WEB-INF/actions/inventory/ReceiveInventory.groovy >>>> >>>> ofbiz/trunk/applications/product/webapp/facility/inventory/receiveInventory.ftl >>>> >>>> ofbiz/trunk/applications/product/webapp/facility/shipment/ShipmentTabBar.ftl >>>> ofbiz/trunk/applications/product/widget/facility/ShipmentForms.xml >>>> ofbiz/trunk/applications/product/widget/facility/ShipmentScreens.xml >>>> >>>> Modified: ofbiz/trunk/applications/order/entitydef/entitymodel.xml >>>> URL: >>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel.xml?rev=895250&r1=895249&r2=895250&view=diff >>>> ============================================================================== >>>> --- ofbiz/trunk/applications/order/entitydef/entitymodel.xml (original) >>>> +++ ofbiz/trunk/applications/order/entitydef/entitymodel.xml Sat Jan 2 >>>> 18:20:19 2010 >>>> @@ -1131,11 +1131,13 @@ >>>> title="Order Shipment Entity"> >>>> <field name="orderId" type="id-ne"></field> >>>> <field name="orderItemSeqId" type="id-ne"></field> >>>> + <field name="shipGroupSeqId" type="id-ne"></field> >>>> <field name="shipmentId" type="id-ne"></field> >>>> <field name="shipmentItemSeqId" type="id-ne"></field> >>>> <field name="quantity" type="fixed-point"></field> >>>> <prim-key field="orderId"/> >>>> <prim-key field="orderItemSeqId"/> >>>> + <prim-key field="shipGroupSeqId"/> >>>> <prim-key field="shipmentId"/> >>>> <prim-key field="shipmentItemSeqId"/> >>>> <relation type="one" fk-name="ORDER_SHPMT_OHDR" >>>> rel-entity-name="OrderHeader"> >>>> @@ -1152,6 +1154,11 @@ >>>> <key-map field-name="shipmentId"/> >>>> <key-map field-name="shipmentItemSeqId"/> >>>> </relation> >>>> + <relation type="one-nofk" rel-entity-name="OrderItemShipGroupAssoc"> >>>> + <key-map field-name="orderId"/> >>>> + <key-map field-name="orderItemSeqId"/> >>>> + <key-map field-name="shipGroupSeqId"/> >>>> + </relation> >>>> </entity> >>>> <entity entity-name="OrderStatus" >>>> package-name="org.ofbiz.order.order" >>>> >>> No, NO NO!. >>> >>> Do not change the primary key of entities. Period. There are >>> procedures for doing this, deprecating the old, making a new. This >>> broke my code. >>> >> See if this can help you: > > Sorry, no. I don't even have to try to know this isn't correct. You > haven't done proper deprecation on the entity. > > You have to rename the entity, then set the table of the renamed old > entity to the correct table name, then create a completely brand new > entity, with whatever changes, then modify the rest of the code to use > the new entity.
You have to deprecate the OrderShipment entity, it has existed since at least July, 2006.
