Hi Adam, please see my comments inline:
On Mar 17, 2010, at 9:22 PM, Adam Heath wrote: > Sorry, no. I don't even have to try to know this isn't correct. You > haven't done proper deprecation on the entity. > calm down, you don't even know what you are talking about. > You have to rename the entity, then set the table of the renamed old > entity to the correct table name, then create a completely brand new > entity, with whatever changes, then modify the rest of the code to use > the new entity. How would the above strategy prevented you to have to know/deal with the change? What I did is exactly inline with the above strategy (I will not call it a "policy", because it isn't a policy in the meaning that you pretend to give it). What you suggest above would have still obliged you to: 1) fix your custom code 2) run the upgrade script that I have provided These are exactly the same steps you have to run after the changes I did - no extra work is required because of my approach. Now, in my self-defense (your tone seems to imply that you have setup a trial on me, the rope is hanging ready for me), I decided to not use the deprecation pattern for two reasons: a) no code was using the OrderShipment entity, no code apart from some old code (that I wrote) related to manufacturing shipment plans: a process that was only partially implemented for manufacturing companies implementing a particular type of fulfillment based on order/manufacturing schedules; I doubt you or anyone else were using this (and for sure not in production because it was not functional complete until my recent changes) b) I have decided to keep the entity model cleaner: we can't limit the OFBiz grow being stuck on code that others could have built outside of OFBiz and kept proprietary; if third parties are doing this then it's fine, they will have to fix the code after the upgrade (I am sure they are prepared for doing this, even if you are not) That said, if you follow my notes you will probably resolve most of the issues you are experiencing and most of all you will help me to test the migration script (in fact I could run it only in a couple of servers so it is still experimental). But we have to be collaborative, relaxed: pointing fingers, judging others' work and screaming is not the right way to interact... at least not the right way to interact with *me*, so please avoid doing this from now on, it really annoys me. Kind regards, Jacopo
