On Mar 19, 2010, at 8:13 PM, Adam Heath wrote: >> >> Where is all this hostility coming from? I sent a simple message, >> saying it should be split(not must).
And you were wrong. >> You responded that it didn't >> need to be, so I assumed that you hadn't seen any of my other emails >> about this subject in the past(entirely possible, we are all busy, and >> may not read everything). So, I happily repeated myself(I have no >> problem doing that). Ok, now I understand your point of view. Yes, I confirm that I also appreciate the value of singleton commits and I always try to implement them (like I did in this commit). >> You then respond with this hostile email. Yes, sorry if I have been too harsh; this happened because it took me a lot of time and energy to reply to all your emails (and Ean's ones) in the last couple of days and I was a bit disappointed (and surprised) when I had to do it again after a such simple commit. >> >> I see what I think are 2 separate changes in a single commit. That >> part was obvious from the initial email I sent. If they weren't meant >> to be split, then explain why. In fact I did it; and it took time; and you could have realized it on your own if you had spent more time reading my code. >> Again, it's obvious I didn't see why >> they could be kept together. It was evident that I didn't see it, >> otherwise, I wouldn't have sent that first email. Of course, I understand you didn't realize. >> >> I've never said that this was a golden rule. Actually I think it is a golden rule (it was not ironic) :-) But of course I am flexible and if I would see you, or Adam or Scott or David breaking it in one of their commits from time to time I would not even think to mention this; I would imply you have good reasons for doing this. Of course if I see committer X breaking this rule in each and every commit I would instead take care of raising an objection. >> I've just explained >> countless times why it is better to keep things separate. Others have >> assumed that it has become a stick to beat people over the head with. > > I also took time out of my schedule to read the commit message. It's > good when this happens. More eyes, etc. Mine too to reply to you. Jacopo > >> >> >
