Scott Gray wrote: > HotWax Media > http://www.hotwaxmedia.com > > On 26/05/2010, at 3:27 PM, Adam Heath wrote: > >> [email protected] wrote: >>> Author: lektran >>> Date: Fri May 14 09:47:14 2010 >>> New Revision: 944179 >>> >>> URL: http://svn.apache.org/viewvc?rev=944179&view=rev >>> Log: >>> The following deprecated methods have been removed from >>> org.ofbiz.base.util.cache.UtilCache: >>> setMaxSize(int) >>> - Use setMaxInMemory(int) instead >>> getMaxSize() >>> - Use getMaxInMemory() instead >>> hasExpired(Object) >>> clearExpired() >>> clearExpiredFromAllCaches() >> I would like this commit to be reverted, and applied later. It's too >> soon to remove the deprecated methods. It makes it harder to maintain >> external code. I'd like to see this reapplied when the next release >> branch is made. >> > > Feel free to revert it, I don't feel like having a discussion about policy > and what's previously been agreed upon right now.
I don't feel all that strongly about it. Reverting code is something that should be done with great care. I just thing that removing deprecated code should be done later, rather than sooner. These methods were only deprecated recently. There hasn't been been an actual real release with this change(just a release branch, which isn't the same thing).
