Scott Gray wrote: > On 27/05/2010, at 1:57 AM, Adam Heath wrote: > >> Scott Gray wrote: >>> On 26/05/2010, at 3:27 PM, Adam Heath wrote: >>> >>>> [email protected] wrote: >>>>> Author: lektran >>>>> Date: Fri May 14 09:47:14 2010 >>>>> New Revision: 944179 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=944179&view=rev >>>>> Log: >>>>> The following deprecated methods have been removed from >>>>> org.ofbiz.base.util.cache.UtilCache: >>>>> setMaxSize(int) >>>>> - Use setMaxInMemory(int) instead >>>>> getMaxSize() >>>>> - Use getMaxInMemory() instead >>>>> hasExpired(Object) >>>>> clearExpired() >>>>> clearExpiredFromAllCaches() >>>> I would like this commit to be reverted, and applied later. It's too >>>> soon to remove the deprecated methods. It makes it harder to maintain >>>> external code. I'd like to see this reapplied when the next release >>>> branch is made. >>>> >>> Feel free to revert it, I don't feel like having a discussion about policy >>> and what's previously been agreed upon right now. >> I don't feel all that strongly about it. Reverting code is something >> that should be done with great care. I just thing that removing >> deprecated code should be done later, rather than sooner. These >> methods were only deprecated recently. There hasn't been been an >> actual real release with this change(just a release branch, which >> isn't the same thing). > > I really don't mind either (despite my mildly grumpy response last night), > this commit was really just a continuation of my efforts to remove deprecated > code with my only rule of thumb being that it was deprecated prior to the > last release branch. > > If it makes your life easier then by all means revert it. Whenever I get > around to working on this sort of thing again I'll focus on code that was > deprecated prior to 9.04 and we can have the discussion about how to proceed > once that is all gone.
to be fair, I don't have anything that depends on this. The code in question was just one of the multitudinous code changes I've done to optimize trunk.
