From: "Hans Bakker" <[email protected]>
Sorry Jacopo, as I already stated, start/stop.sh and perhaps also the windows
ones should stay in the root.
I use Windows one, though not in for CI (I rely on Buildbot for that, too bad those days). It was not a pb for me to add \tools
where necessary. I can't see that as a tremendous change and agree it should not be reverted. Hans, naybe it's acceptable the time
you adapt your scripts though... We can't freeze OFBiz and have to move ahead, based on consensus or vote, of course...
Jacques
They are operational-, not tools scripts.
further was looking if i could make them work in the root and then i saw they were heavily modified without documentation so i
reverted also that.
Regards,
Hans
On 03/24/2012 12:42 PM, Jacopo Cappellato wrote:
On Mar 24, 2012, at 1:44 AM, Hans Bakker wrote:
AND make a number of changes not documented in the log message is not the way
to go
The "undocumented" changes are actually documented by the sentence in my log: "Moved all platform dependent scripts to the "tool"
folder [...]"
In fact the purpose of the changes I did was to make them work in the new location: I didn't add or change behavior and so I have
actually simply documented the commit with that sentence.
I agree I should have better specified what I did with something like:
"Moved all platform dependent scripts to the "tool" folder (and made required
changes to the scripts) [...]"
Jacopo
