As I mentioned in Jira, I am not against this change (i.e. switch from FastMap to Hashmap) but I doubt this is related to the issue you were experiencing.
Jacopo On Jun 30, 2012, at 10:15 AM, [email protected] wrote: > Author: jleroux > Date: Sat Jun 30 08:15:42 2012 > New Revision: 1355660 > > URL: http://svn.apache.org/viewvc?rev=1355660&view=rev > Log: > "Login out on a cluster handled by DeltaManager causes a NPE" > https://issues.apache.org/jira/browse/OFBIZ-4289 > > Uses a HashMap instead of a FastMap here because else we get this kind of > error when OFBiz is shut down: > > 2012-06-12 10:35:29,921 (OFBiz_Shutdown_Hook) [ > StandardSession.java:1567:WARN ] Cannot serialize session attribute > LAST_VIEW_PARAMS for session 00C48D0D76821C98403482FAE8B77C24.jvm1 > java.io.NotSerializableException: net.sf.json.JSONObject > at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164) > at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330) > at javolution.util.FastMap.writeObject(FastMap.java:1513) > > Modified: > ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java > > Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java?rev=1355660&r1=1355659&r2=1355660&view=diff > ============================================================================== > --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java > (original) > +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java Sat Jun > 30 08:15:42 2012 > @@ -113,7 +113,7 @@ public class UtilHttp { > */ > public static Map<String, Object> getParameterMap(HttpServletRequest > request, Set<? extends String> nameSet, Boolean onlyIncludeOrSkip) { > boolean onlyIncludeOrSkipPrim = onlyIncludeOrSkip == null ? true : > onlyIncludeOrSkip.booleanValue(); > - Map<String, Object> paramMap = FastMap.newInstance(); > + Map<String, Object> paramMap = new HashMap<String, Object>(); > > // add all the actual HTTP request parameters > Enumeration<String> e = > UtilGenerics.cast(request.getParameterNames()); > >
