I think in general, Jacques does an excellent job, however if you do a
lot of commits, yes sure you have more errors than if you only do a few.
If he would not be here, hardly anything gets committed from contributors.
For very complicated (framework) contributions I agree however simple
ones and in the applications I do not agree.
Regards,
Hans
On 07/01/2012 03:37 PM, Jacopo Cappellato wrote:
Jacques,
since in the past you have committed a series of contributions from others that
were implemented in a questionable way and are requiring a considerable effort
to be fixed, I would like to ask you to change your protocol for committing
them to OFBiz: if you are interested in committing something, then review and
test it completely; then ask committers to confirm that it is a good
contribution and if no answer is received then please hold on because it means
that no other committer was either interested or had time to review it.
It is better to move slowly and focus on quality.
What do the other committers think about this?
Kind regards,
Jacopo
On Jul 1, 2012, at 9:22 AM, Jacques Le Roux wrote:
https://issues.apache.org/jira/browse/OFBIZ-4944
This seems a good idea to me (did not review details yet), if nobody is against
(no answer implies OK), I will commit
Jacques
